From 0b40022f2c30b7c0a07cac5f3d03955cda4f394e Mon Sep 17 00:00:00 2001
From: tsteven4 <13596209+tsteven4@users.noreply.github.com>
Date: Sun, 20 Nov 2022 08:16:37 -0700
Subject: [PATCH] fix tidy performance-unnecessary-copy-initialization

manual fix.  also fixes an instance of modernize-loop-convert
---
 gui/mainwindow.cc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gui/mainwindow.cc b/gui/mainwindow.cc
index ac0643bde..78b632b98 100644
--- a/gui/mainwindow.cc
+++ b/gui/mainwindow.cc
@@ -117,8 +117,7 @@ bool MainWindow::allowBetaUpgrades()
 static QString MakeOptions(const QList<FormatOption>& options)
 {
   QString str;
-  for (int i = 0; i< options.size(); i++) {
-    FormatOption option = options[i];
+  for (const auto& option : options) {
     QVariant default_value = option.getDefaultValue();
     if (option.getSelected()) {
       // For OPTbool, 'selected' is the key, not value.
-- 
2.30.2